Difference between revisions of "Reviewing Octave Forge packages"

From Octave
Jump to navigation Jump to search
(→‎Checklist: Review list)
 
(6 intermediate revisions by the same user not shown)
Line 5: Line 5:
 
# Pick a package at https://sourceforge.net/p/octave/package-releases/
 
# Pick a package at https://sourceforge.net/p/octave/package-releases/
 
# Copy the check-list below and fill it out, marking each box:
 
# Copy the check-list below and fill it out, marking each box:
#* <code>[x]</code> for passed
+
#* <code>[x]</code> for successfully passed
#* <code>[n/a]</code> for non-applicable
+
#* <code>[ ]</code> for not done / error (please give below the checklist a brief reason)
#* <code>[ ]</code> for skipped (because you cannot do it, missing software, etc)
 
#* <code>[F]</code> for fails.
 
 
# Paste your filled in check-list as a comment on the issue above
 
# Paste your filled in check-list as a comment on the issue above
 
# An [https://sourceforge.net/p/octave/_members/ Octave Forge Admin] will try to look over your review and hopefully release the package.
 
# An [https://sourceforge.net/p/octave/_members/ Octave Forge Admin] will try to look over your review and hopefully release the package.
Line 15: Line 13:
  
 
<pre>
 
<pre>
# Repository
+
# Repository / Metadata
  
- [ ] maintainer has specified a corresponding revision commit/changeset
+
- [ ] release commit/changeset specified and present in repository
- [ ] checkout code from Sourceforge, commit/changeset is present
+
- [ ] `generate_package_html` / `make html` works without errors and warnings
 +
- [ ] generated HTML documentation looks sane
  
# Compile and Install
+
# pkg-tool runs without errors or warnings
 
 
- [ ] release candidate installs on latest stable Octave release
 
- [ ] no compiler errors or warnings
 
- [ ] ran tests using <code>runtests /path/to/pkg</code> (use <code>oruntests</code> instead in Octave 6.0.0 or later)
 
- [ ] ran all tests, including those in src (how??)
 
- [ ] ran doctest on all functions (optional)
 
- [ ] ran generate_package_html (if Makefile present try <code> make html </code>)
 
- [ ] no makeinfo errors and warnings during HTML build
 
- [ ] unpacked and spot-checked the generated HTML documentation
 
 
 
# `pkg`-tool runs without errors or warnings
 
  
 +
- [ ] `pkg install  foo`
 
- [ ] `pkg load      foo`
 
- [ ] `pkg load      foo`
 
- [ ] `pkg unload    foo`
 
- [ ] `pkg unload    foo`
 
- [ ] `pkg uninstall foo`
 
- [ ] `pkg uninstall foo`
- [ ] Above steps were run on Octave and OS versions:
+
- Above steps were run on Octave and OS versions:
      -  ________
+
  -  ________
      -  ________
+
  -  ________
 +
 
 +
# Package tests
 +
 
 +
- [ ] ran `pkg test foo`
 +
- [ ] ran `doctest`
  
 
# Package files in release candidate tarball
 
# Package files in release candidate tarball
  
- [ ] `DESCRIPTION` version updated
+
- [ ] `DESCRIPTION` version and release date updated
 
- [ ] `DESCRIPTION` minimum Octave tested
 
- [ ] `DESCRIPTION` minimum Octave tested
 
- [ ] `DESCRIPTION` all dependencies are listed
 
- [ ] `DESCRIPTION` all dependencies are listed
Line 54: Line 48:
 
- [ ] (optional if present) `src/configure.ac` version updated
 
- [ ] (optional if present) `src/configure.ac` version updated
 
</pre>
 
</pre>
 +
 +
== Admin tasks ==
 +
 +
# Upload release tarball to [https://sourceforge.net/projects/octave/files/Octave%20Forge%20Packages/Individual%20Package%20Releases/ Individual Package Releases]
 +
# Update https://octave.sourceforge.io/
 +
## Upload new package HTML documentation to {{Path|/home/project-web/octave/htdocs/packages/foo/}} <ref>How to access the Octave Forge webspace [https://sourceforge.net/p/forge/documentation/Project%20Web%20Services/ SourceForge help].</ref>
 +
## Update news feed, add entry in [https://sourceforge.net/p/octave/project-web/ci/default/tree/htdocs/news.html htdocs/news.html]
 +
 +
== Footnotes ==
 +
 +
<references/>
  
 
[[Category:Octave Forge]]
 
[[Category:Octave Forge]]

Latest revision as of 18:52, 16 February 2021

Info icon.svg
More than one person can review a package, in fact that would be great.

The reviewing procedure in short:

  1. Pick a package at https://sourceforge.net/p/octave/package-releases/
  2. Copy the check-list below and fill it out, marking each box:
    • [x] for successfully passed
    • [ ] for not done / error (please give below the checklist a brief reason)
  3. Paste your filled in check-list as a comment on the issue above
  4. An Octave Forge Admin will try to look over your review and hopefully release the package.

Checklist[edit]

# Repository / Metadata

- [ ] release commit/changeset specified and present in repository
- [ ] `generate_package_html` / `make html` works without errors and warnings
- [ ] generated HTML documentation looks sane

# pkg-tool runs without errors or warnings

- [ ] `pkg install   foo`
- [ ] `pkg load      foo`
- [ ] `pkg unload    foo`
- [ ] `pkg uninstall foo`
- Above steps were run on Octave and OS versions:
  -  ________
  -  ________

# Package tests

- [ ] ran `pkg test foo`
- [ ] ran `doctest` 

# Package files in release candidate tarball

- [ ] `DESCRIPTION` version and release date updated
- [ ] `DESCRIPTION` minimum Octave tested
- [ ] `DESCRIPTION` all dependencies are listed
- [ ] `NEWS` version and date match
- [ ] `NEWS` big changes announced
- [ ] `INDEX` all (new) functions are listed
- [ ] version numbers in help text and function body (e.g., banners) updated
- [ ] license specifications in help text and function body agree `licensecheck -r`
- [ ] file permissions are readable/executable by all users
- [ ] junk files are removed (hidden dot files, backup files, results of configure runs, etc.)
- [ ] (optional if present) `src/configure.ac` version updated

Admin tasks[edit]

  1. Upload release tarball to Individual Package Releases
  2. Update https://octave.sourceforge.io/
    1. Upload new package HTML documentation to /home/project-web/octave/htdocs/packages/foo/ [1]
    2. Update news feed, add entry in htdocs/news.html

Footnotes[edit]

  1. How to access the Octave Forge webspace SourceForge help.