657
edits
m (→Other info: check INDEX) |
|||
(6 intermediate revisions by 3 users not shown) | |||
Line 1: | Line 1: | ||
== Help reviewing Octave | == Help reviewing Octave Forge packages == | ||
We need help. Here is how: | We need help. Here is how: | ||
Line 22: | Line 22: | ||
[ ] maintainer has specified a corresponding revision commit/changeset | [ ] maintainer has specified a corresponding revision commit/changeset | ||
[ ] checkout code from Sourceforge, commit/changeset is present | [ ] checkout code from Sourceforge, commit/changeset is present | ||
== Compile and Install == | == Compile and Install == | ||
[ ] release candidate installs on latest stable Octave release | [ ] release candidate installs on latest stable Octave release | ||
[ ] no compiler errors or warnings | [ ] no compiler errors or warnings | ||
[ ] ran tests using <code>runtests /path/to/pkg</code> | [ ] ran tests using <code>runtests /path/to/pkg</code> (use <code>oruntests</code> instead in Octave 6.0.0 or later) | ||
[ ] ran all tests, including those in src (how??) | [ ] ran all tests, including those in src (how??) | ||
[ ] ran doctest on all functions (optional) | [ ] ran doctest on all functions (optional) | ||
Line 31: | Line 32: | ||
[ ] no makeinfo errors and warnings during HTML build | [ ] no makeinfo errors and warnings during HTML build | ||
[ ] unpacked and spot-checked the generated HTML documentation | [ ] unpacked and spot-checked the generated HTML documentation | ||
== Interaction with pkg == | == Interaction with pkg == | ||
[ ] <code>pkg load foo</code> runs with errors or warnings | [ ] <code>pkg load foo</code> runs with errors or warnings | ||
Line 40: | Line 42: | ||
* ________ | * ________ | ||
== Package files == | == Package files in release candidate tarball == | ||
[ ] tested with minimum Octave version list in DESCRIPTION | [ ] tested with minimum Octave version list in DESCRIPTION | ||
[ ] reasonable dependencies listed in DESCRIPTION | [ ] reasonable dependencies listed in DESCRIPTION | ||
[ ] NEWS file makes sense, version and date match | [ ] NEWS file makes sense, version and date match | ||
[ ] All functions are listed in INDEX | [ ] All functions are listed in INDEX | ||
[ ] check licenses (<code>licensecheck -r</code> "plus some manual checks"). | |||
[ ] package files are readable/executable by all users (reasonably current maintainer Makefile should be doing this). | |||
[ ] version number in src/configure.ac (if present) matches DESCRIPTION and tarball name. | |||
[ ] any version numbers within the help or function body (e.g., banners) matches above. | |||
[ ] contains no hidden dot files, junk backup files, results of configure runs, etc (should be taken care of by maintainer Makefile). | |||
</pre> | </pre> | ||
Line 50: | Line 57: | ||
TODO: how does one check all functions are listed in INDEX? | TODO: how does one check all functions are listed in INDEX? | ||
: Carne Draug wrote a script to do this several years ago. It is in the [https://sourceforge.net/p/octave/code/HEAD/tree/trunk/octave-forge/admin/check_INDEX.pl old OF admin repository] [[User:KaKiLa|KaKiLa]] ([[User talk:KaKiLa|talk]]) 07:56, 20 November 2019 (PST) | |||
TODO: document how to run "all tests including those in src" Someday this should be just "pkg test foo". | TODO: document how to run "all tests including those in src" Someday this should be just "pkg test foo". | ||
Line 72: | Line 81: | ||
[[Category:Octave Forge]] | [[Category:Octave Forge]] | ||
edits