Editing PVS static analyzer - 5.0 Release
The edit can be undone. Please check the comparison below to verify that this is what you want to do, and then publish the changes below to finish undoing the edit.
Latest revision | Your text | ||
Line 6,843: | Line 6,843: | ||
</tr> | </tr> | ||
<tr> | <tr> | ||
<td style='width: 30% | <td style='width: 30%;'><div title="/home/pavel/octave/libinterp/corefcn/ls-hdf5.cc">ls-hdf5.cc (1011)</div></td> | ||
<td style='width: 5%;'>[https://www.viva64.com/en/w/v547/ V547]</td> | <td style='width: 5%;'>[https://www.viva64.com/en/w/v547/ V547]</td> | ||
<td style='width: 65%;'>Expression 'retval >= 0' is always true.</td> | <td style='width: 65%;'>Expression 'retval >= 0' is always true.</td> | ||
Line 6,898: | Line 6,898: | ||
</tr> | </tr> | ||
<tr> | <tr> | ||
<td style='width: 30% | <td style='width: 30%;'><div title="/home/pavel/octave/libinterp/corefcn/lu.cc">lu.cc (171)</div></td> | ||
<td style='width: 5%;'>[https://www.viva64.com/en/w/v656/ V656]</td> | <td style='width: 5%;'>[https://www.viva64.com/en/w/v656/ V656]</td> | ||
<td style='width: 65%;'>Variables 'thres(0)', 'thres(1)' are initialized through the call to the same function. It's probably an error or un-optimized code. Consider inspecting the 'tmp(0)' expression. Check lines: 170, 171.</td> | <td style='width: 65%;'>Variables 'thres(0)', 'thres(1)' are initialized through the call to the same function. It's probably an error or un-optimized code. Consider inspecting the 'tmp(0)' expression. Check lines: 170, 171.</td> | ||
Line 9,928: | Line 9,928: | ||
</tr> | </tr> | ||
<tr> | <tr> | ||
<td style='width: 30% | <td style='width: 30%;'><div title="/home/pavel/octave/liboctave/numeric/EIG.cc">EIG.cc (136)</div></td> | ||
<td style='width: 5%;'>[https://www.viva64.com/en/w/v550/ V550]</td> | <td style='width: 5%;'>[https://www.viva64.com/en/w/v550/ V550]</td> | ||
<td style='width: 65%;'>An odd precise comparison: wi.elem(j) == 0.0. It's probably better to use a comparison with defined precision: fabs(A - B) < Epsilon.</td> | <td style='width: 65%;'>An odd precise comparison: wi.elem(j) == 0.0. It's probably better to use a comparison with defined precision: fabs(A - B) < Epsilon.</td> | ||
</tr> | </tr> | ||
<tr> | <tr> | ||
<td style='width: 30% | <td style='width: 30%;'><div title="/home/pavel/octave/liboctave/numeric/EIG.cc">EIG.cc (490)</div></td> | ||
<td style='width: 5%;'>[https://www.viva64.com/en/w/v550/ V550]</td> | <td style='width: 5%;'>[https://www.viva64.com/en/w/v550/ V550]</td> | ||
<td style='width: 65%;'>An odd precise comparison: ai.elem(j) == 0.0. It's probably better to use a comparison with defined precision: fabs(A - B) < Epsilon.</td> | <td style='width: 65%;'>An odd precise comparison: ai.elem(j) == 0.0. It's probably better to use a comparison with defined precision: fabs(A - B) < Epsilon.</td> | ||
Line 9,953: | Line 9,953: | ||
</tr> | </tr> | ||
<tr> | <tr> | ||
<td style='width: 30% | <td style='width: 30%;'><div title="/home/pavel/octave/liboctave/numeric/LSODE.cc">LSODE.cc (440)</div></td> | ||
<td style='width: 5%;'>[https://www.viva64.com/en/w/v550/ V550]</td> | <td style='width: 5%;'>[https://www.viva64.com/en/w/v550/ V550]</td> | ||
<td style='width: 65%;'>An odd precise comparison: next_crit == next_out. It's probably better to use a comparison with defined precision: fabs(A - B) < Epsilon.</td> | <td style='width: 65%;'>An odd precise comparison: next_crit == next_out. It's probably better to use a comparison with defined precision: fabs(A - B) < Epsilon.</td> | ||
Line 10,358: | Line 10,358: | ||
</tr> | </tr> | ||
<tr> | <tr> | ||
<td style='width: 30% | <td style='width: 30%;'><div title="/home/pavel/octave/liboctave/numeric/oct-norm.cc">oct-norm.cc (466)</div></td> | ||
<td style='width: 5%;'>[https://www.viva64.com/en/w/v764/ V764]</td> | <td style='width: 5%;'>[https://www.viva64.com/en/w/v764/ V764]</td> | ||
<td style='width: 65%;'>Possible incorrect order of arguments passed to 'dual_p' function: 'q' and 'p'.</td> | <td style='width: 65%;'>Possible incorrect order of arguments passed to 'dual_p' function: 'q' and 'p'.</td> | ||
Line 10,523: | Line 10,523: | ||
</tr> | </tr> | ||
<tr> | <tr> | ||
<td style='width: 30% | <td style='width: 30%;'><div title="/home/pavel/octave/liboctave/system/lo-sysdep.cc">lo-sysdep.cc (173)</div></td> | ||
<td style='width: 5%;'>[https://www.viva64.com/en/w/v575/ V575]</td> | <td style='width: 5%;'>[https://www.viva64.com/en/w/v575/ V575]</td> | ||
<td style='width: 65%;'>The potential null pointer is passed into 'sprintf' function. Inspect the first argument. Check lines: 173, 171.</td> | <td style='width: 65%;'>The potential null pointer is passed into 'sprintf' function. Inspect the first argument. Check lines: 173, 171.</td> | ||
</tr> | </tr> | ||
<tr> | <tr> | ||
<td style='width: 30% | <td style='width: 30%;'><div title="/home/pavel/octave/liboctave/system/lo-sysinfo.cc">lo-sysinfo.cc (69)</div></td> | ||
<td style='width: 5%;'>[https://www.viva64.com/en/w/v547/ V547]</td> | <td style='width: 5%;'>[https://www.viva64.com/en/w/v547/ V547]</td> | ||
<td style='width: 65%;'>Expression '!retval.empty()' is always false.</td> | <td style='width: 65%;'>Expression '!retval.empty()' is always false.</td> | ||
Line 10,758: | Line 10,758: | ||
</tr> | </tr> | ||
<tr> | <tr> | ||
<td style='width: 30% | <td style='width: 30%;'><div title="/home/pavel/octave/liboctave/util/oct-mutex.cc">oct-mutex.cc (45)</div></td> | ||
<td style='width: 5%;'>[https://www.viva64.com/en/w/v524/ V524]</td> | <td style='width: 5%;'>[https://www.viva64.com/en/w/v524/ V524]</td> | ||
<td style='width: 65%;'>It is odd that the body of 'unlock' function is fully equivalent to the body of 'lock' function.</td> | <td style='width: 65%;'>It is odd that the body of 'unlock' function is fully equivalent to the body of 'lock' function.</td> |