16
edits
Line 23: | Line 23: | ||
===Notes by Amod Mulay(white)=== | ===Notes by Amod Mulay(white)=== | ||
The snippets above define the point in execution where the jit code is called. | The snippets above define the point in execution where the jit code is called. | ||
All of the | All of the files for jit implementation are in libinterp/interp-core, the main files are: | ||
*pt-jit.cc (& pt-jit.h) | *pt-jit.cc (& pt-jit.h) | ||
*jit-ir.cc (& jit-ir.h) | *jit-ir.cc (& jit-ir.h) | ||
Line 29: | Line 29: | ||
*jit-util.cc (& jit-util.h) | *jit-util.cc (& jit-util.h) | ||
I haven't gone through all parts of the code yet and dont understand a lot of it, but my first impression is that it feels like more of a text dump. The various parts need to be seperated into different files based on functionality. The current files are a tad too big | I haven't gone through all parts of the code yet and dont understand a lot of it, but my first impression is that it feels like more of a text dump. The various parts need to be seperated into different files based on functionality. The current files are a tad too big IMHO. Right now all of the jit parts are in 4 files(+4 header files) which are quite large and a lot of it has no documentaion to explain how the different parts come togeather. | ||
To be fair my impressions/opinions are that of a beginner level user and you are welcome to have a look and post your own comments. | To be fair my impressions/opinions are that of a beginner level user and you are welcome to have a look and post your own comments. |
edits